Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Hide visible pink line below nav element #3628

Merged
merged 3 commits into from
Jul 22, 2020
Merged

Hide visible pink line below nav element #3628

merged 3 commits into from
Jul 22, 2020

Conversation

RichardPK
Copy link
Contributor

@RichardPK RichardPK commented Jul 22, 2020 •
edited
Loading

Resolves #bbc/simorgh#6602

Overall change:

  • Removing the bottom line beneath the nav element

Code changes:

  • Used bottom: -1px to mask the :after at the bottom of the nav element.

Visual

Before:
before

After:
after

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@RichardPK RichardPK added ws-media The World Service media stream ux To be reviewed by UX before merging labels Jul 22, 2020
@RichardPK RichardPK self-assigned this Jul 22, 2020
@RichardPK RichardPK marked this pull request as ready for review July 22, 2020 15:14
ryanmccombe
ryanmccombe approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@ryanmccombe ryanmccombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RichardPK RichardPK merged commit a2541ae into latest Jul 22, 2020
@RichardPK RichardPK deleted the pink-nav-line branch July 22, 2020 15:26
@FK78 FK78 mentioned this pull request Jul 22, 2020
Closed
1 task
@bbc-news-frameworks bbc-news-frameworks mentioned this pull request Jul 22, 2020
Merged
@RichardPK RichardPK mentioned this pull request Jul 23, 2020
Merged
2 tasks
@thekp thekp mentioned this pull request Jul 23, 2020
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karinathomasbbc karinathomasbbc karinathomasbbc approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

Assignees

@RichardPK RichardPK

Labels
ux To be reviewed by UX before merging ws-media The World Service media stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardPK @ryanmccombe @karinathomasbbc