Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add stories in storybook for media icons in psammead-assets #2189

Merged
merged 9 commits into from
Sep 23, 2019
Merged

Add stories in storybook for media icons in psammead-assets #2189

merged 9 commits into from
Sep 23, 2019

Conversation

EinsteinNjoroge
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge commented Sep 19, 2019 •
edited
Loading

Resolves #2158

Overall change: Add stories in psammead storybook for media icons SVGs in psammead-assets.

Code changes:

  • Group Brand svg in storybook.
  • Add media icons stories in storybook.

Screenshots:
Screen Shot 2019-09-19 at 5 08 35 PM

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@EinsteinNjoroge EinsteinNjoroge self-assigned this Sep 19, 2019
@EinsteinNjoroge EinsteinNjoroge added shared-components ws-home Tasks for the WS Home Team labels Sep 19, 2019
@EinsteinNjoroge EinsteinNjoroge marked this pull request as ready for review September 19, 2019 14:11
ghost
ghost suggested changes Sep 20, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add notes to Utilities|SVGs/MediaIcon Svgs

j-pendlebury
j-pendlebury approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EinsteinNjoroge EinsteinNjoroge merged commit b6ab464 into latest Sep 23, 2019
@EinsteinNjoroge EinsteinNjoroge deleted the add-mediaicons-stories-to-psammead-assets branch September 23, 2019 10:34
This was referenced Sep 23, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DenisHdz DenisHdz DenisHdz approved these changes

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@Bopchy Bopchy Bopchy approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@EinsteinNjoroge EinsteinNjoroge

Labels
shared-components ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add stories in storybook for media icons in psammead-assets
4 participants
@EinsteinNjoroge @Bopchy @j-pendlebury @DenisHdz