Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Optimise Navigation direction prop #2117

Merged
merged 12 commits into from
Sep 16, 2019
Merged

Optimise Navigation direction prop #2117

merged 12 commits into from
Sep 16, 2019

Conversation

DenisHdz
Copy link
Contributor

Resolves #NaN

Overall change:
Refactor Navigation to pass the dir prop to the main wrapper to avoid adding it to every link.

Code changes:

  • Target the StyledListItem from the StyledNav and modify the CSS depending on the direction.
  • Pass dir prop to the Navigation in the story.
  • Update snapshots
  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added the ws-home Tasks for the WS Home Team label Sep 12, 2019
@DenisHdz DenisHdz self-assigned this Sep 12, 2019
@DenisHdz DenisHdz changed the title Optimize Navigation direction Optimise Navigation direction prop Sep 12, 2019
@DenisHdz DenisHdz mentioned this pull request Sep 13, 2019
Closed
1 task
ghost
ghost approved these changes Sep 13, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paruchurisilpa
Copy link
Contributor

Looks good to me..

@DenisHdz DenisHdz merged commit 6208ecf into latest Sep 16, 2019
@DenisHdz DenisHdz deleted the navigation-direction branch September 16, 2019 13:36
@pharingee pharingee mentioned this pull request Oct 15, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sareh sareh sareh left review comments

@dr3 dr3 dr3 approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@jroebu14 jroebu14 Awaiting requested review from jroebu14

Assignees

@paruchurisilpa paruchurisilpa

@DenisHdz DenisHdz

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DenisHdz @paruchurisilpa @sareh @ryanmccombe @dr3