Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation direction #3720

Closed
1 task done
DenisHdz opened this issue Sep 13, 2019 · 0 comments · Fixed by #3808
Closed
1 task done

Navigation direction #3720

DenisHdz opened this issue Sep 13, 2019 · 0 comments · Fixed by #3808
Assignees

Comments

@DenisHdz
Copy link
Contributor

DenisHdz commented Sep 13, 2019

Is your feature request related to a problem? Please describe.
We are not passing the direction to the Navigation so the dividers lines are wrong for rtl scripts as the CSS is not applied properly.

navigation-dir

Describe the solution you'd like
Get the direction from the service config file in the Navigation Container and pass it to the Navigation component as a prop.

<Navigation script={script} skipLinkText={skipLinkText} service={service}> dir={dir}

Describe alternatives you've considered
N/A

Testing notes
[Tester to complete]

Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc

  • This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.

@DenisHdz DenisHdz added blocked This issue should not be worked on until another internal issue is completed - see desc for details Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-frontpage-stream labels Sep 13, 2019
@DenisHdz DenisHdz added this to the Navigation (WS FP) milestone Sep 13, 2019
@DenisHdz DenisHdz removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 16, 2019
@DenisHdz DenisHdz self-assigned this Sep 16, 2019
@DenisHdz DenisHdz removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant