This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Consent banner stories for all services #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sareh
changed the title
|
Talking with Clare and Laura, they were happy with just having placeholder text rather than having the exact translation used in Storybook, so that's what I've implemented here. |
ryanmccombe
reviewed
Jul 19, 2019
| name: 'text', | ||
| defaultText: 'Changes to our Privacy and Cookie Policy ', | ||
| }, | ||
| { name: 'acceptText', defaultText: 'OK' }, |
There was a problem hiding this comment.
Doesn't look like the acceptText or rejectText knobs are being used for anything - the text knob is being used 3 times instead
ryanmccombe
approved these changes
Jul 19, 2019
dr3
approved these changes
Jul 22, 2019
|
Thanks, I've just made the changes. :) |
|
Done regression on storybook and looks good to me, can be merged.. |
dr3
approved these changes
Jul 23, 2019
This was referenced Oct 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #700
Overall change: Updates consent banner's storybook to have placeholder text. Can use the drop-down to select a different script.
Code changes:
When selecting from the drop-down, you should be able to change the text and see placeholder text for the relevant language/script.