Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

ConsentBanner stories need translations and knobs #700

Closed
pjlee11 opened this issue Jun 25, 2019 · 6 comments · Fixed by #1366
Closed

ConsentBanner stories need translations and knobs #700

pjlee11 opened this issue Jun 25, 2019 · 6 comments · Fixed by #1366
Assignees
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. shared-components

Comments

@pjlee11
Copy link
Contributor

pjlee11 commented Jun 25, 2019

Is your feature request related to a problem? Please describe.
Following #667 the ConsentBanner is now in Storybook. We should add stories for non-latin services including translations and typography that match the requested service. Similar to how the Paragraph stories work

Describe the solution you'd like

  • Add ConsentBanner translation config for each service from here
  • Add Knobs to the ConsentBanner stories that allow for swapping in and out the service

Describe alternatives you've considered
N/A

Testing notes
Manual testing only

Dev insight: Regression of storybook should be performed

Additional context

@pjlee11 pjlee11 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-home Tasks for the WS Home Team simorgh-core-stream labels Jun 25, 2019
@dr3
Copy link
Contributor

dr3 commented Jun 26, 2019

@pjlee11 Is this saying we should have translations for all our services in psammead as well as simorgh? Seems like a lot to keep in 2 places. Or can we just use generic text from the input provider?

@pjlee11
Copy link
Contributor Author

pjlee11 commented Jun 26, 2019

I mean generic text. I personally think we should be better at using place holder text rather than real text and it makes it easier to understand that each component in the component library is very flexible.

Ideally we could have fixtures in psammead along the lines of:

  • "A short headline"
  • "A headline that is a bit longer than other headlines for testing"
  • "Some text"
  • "Some text that is significantly longer and therefore should carry on filling up space so we can see how it wraps and also interacts within the component it is used within"
  • "Yes" (OR "Option 1")
  • "No" (OR "Option 2")
  • "Some summary text that would describe the story and give more context to what it is about"
    ...

Then our stories can utilise a base of generic translations per service rather than having each component define it's own "real world" translations. Also we can offer input boxes so that any string could be entered to see how it interacts with the given component

@greenc05
Copy link
Contributor

Realistic text would make components easier to review and understand - particularly from a UX and accessibility swarm point of view

@pjlee11
Copy link
Contributor Author

pjlee11 commented Jun 27, 2019

@greenc05 for offscreen text I agree it should be accurate, but the placeholder text in the component IMO should just be filler

@greenc05
Copy link
Contributor

greenc05 commented Jul 1, 2019

It can be a filler but it should make sense within the component

@j-pendlebury j-pendlebury removed the ws-home Tasks for the WS Home Team label Jul 17, 2019
@sareh sareh self-assigned this Jul 18, 2019
@sareh
Copy link
Contributor

sareh commented Jul 19, 2019

Talking with Clare and Laura, they were happy with just having placeholder text rather than having the exact translation used in Storybook, so I've implemented that in the PR: #1366

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. shared-components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants