Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome resize video #34

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Chrome resize video #34

merged 2 commits into from
Oct 18, 2019

Conversation

emettely
Copy link
Contributor

@emettely emettely commented Oct 18, 2019 •
edited
Loading

Is your Pull Request request related to another issue in this repository ?
bbc/digital-paper-edit-client#78

Describe what the PR does

  • Added story preview to show the video context and programme script container together in columns to see what it would look like once rendered.
  • deployed to NPM and ghpages https://bbc.github.io/digital-paper-edit-storybook/
  • added properties width and height so that it is configurable at a higher level.

State whether the PR is ready for review or whether it needs extra work
ready

Additional context

@emettely emettely self-assigned this Oct 18, 2019
@emettely emettely merged commit 9b5b8bd into master Oct 18, 2019
@emettely emettely deleted the chrome-resize-video branch October 18, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emettely emettely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emettely