Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change DebugTool.error usages in captions.js to info #22

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

jlks
Copy link
Contributor

@jlks jlks commented Nov 29, 2018

The current implementation is wrong, DebugTool.error expects a particular object format... info() is a better fit for logs like this.

@jlks jlks added the bug Something isn't working label Nov 29, 2018
@jlks jlks requested a review from a team November 29, 2018 11:55
Copy link
Contributor

@ShiningTrapez ShiningTrapez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Luke-Chatburn Luke-Chatburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, to fix the issue but would make more sense if we changed the debug tool error to not require a specific format. Sending info for an error seems strange?

@jlks jlks merged commit 023ba76 into master Dec 7, 2018
@jlks jlks deleted the correct-debug-tool-usage branch December 7, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants