-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing main element as well as main role #336
Conversation
Hi @votemike Thanks for your PR! This kind of change has been suggested before in #328 but it was declined - see that PR for reasoning. @EmmaJP & @JamieKnightBBC - Can I check our position hasn't changed on requiring |
I see. That's a pain. It seems like that is because |
We actually looked at this again fairly recently, when updating the HTML guidance (refer https://www.bbc.co.uk/accessibility/forproducts/guides/html/landmarks/) and our conversation still steered us toward including the explicit role attribute and not solely relying on support for the native element. Hopefully at some point in the not too distant future all browsers the BBC has to be mindful of will have full support of the native elements, as the older browsers become less used. |
Support for IE11 (and all IEs) runs out next Wednesday on June 15, 2022. https://blogs.windows.com/windowsexperience/2021/05/19/the-future-of-internet-explorer-on-windows-10-is-in-microsoft-edge/ Is it worth reviewing this now? |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Hi @votemike, @EmmaJP and I both no longer work for BBC so we no longer maintain this repo. @nicholasgriffintn - are you contributing to this repo now? Do you know who else is maintaining? |
I'm not contributing directory no, just sorted out some of the contributing stuff and the CI, there are a few talks about this repo internally going on, I'm not sure about if this is going to happen or not, at all tbh. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Looking at out guidelines: https://www.bbc.co.uk/accessibility/forproducts/guides/html/landmarks/
Rather than keeping this PR alive by removing the |
Summary
Allow
<main>
as well as <element role="main'> as this is even more valid.https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Main_role
Details
Also changed message to that people are aware they can use the
<main>
element.Motivation and Context
NextJS uses a
<main>
element by default, but bbc-a11y does not like that there is no role="main"How Has This Been Tested?
Added/updated tests
Screenshots (if appropriate):
Types of changes
Checklist: