Ignore cached project roots that point to nonexistent directories. #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good. Note it in the changelog and drop the |
| @@ -790,7 +790,7 @@ The current directory is assumed to be the project's root otherwise." | |||
| (let ((dir default-directory)) | |||
| (or (--some (let* ((cache-key (format "%s-%s" it dir)) | |||
| (cache-value (gethash cache-key projectile-project-root-cache))) | |||
| (if cache-value | |||
| (if (and cache-value (file-exists-p cache-value)) | |||
There was a problem hiding this comment.
Btw, this change might be problematic for tramp users, as such checks are very slow there.
This fixes an awkward bug when the current project is a symlink that
changes. Suppose we have the following filesystem layout:
/tmp/projectile_project -> /tmp/first_project
If we now delete /tmp/first_project and change the symlink:
/tmp/projectile_project -> /tmp/second_project
then `projectile-project-root-cache` will contain a key
`"projectile-root-bottom-up-/tmp/projectile-project"` with value
`"/tmp/first_project"`. This will stop `projectile-find-file` from working
as it can't cd to /tmp/first_project.
Instead, we enforce that the string from `projectile-project-root`
points to a directory that currently exists.
Wilfred
force-pushed
the
changing_symlinks
branch
from
541df21
to
2bc6105
Compare
|
@bbatsov thanks, changelog and commit message updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an awkward bug when the current project is a symlink that
changes. Suppose we have the following filesystem layout:
If we now delete /tmp/first_project and change the symlink:
then
projectile-project-root-cachewill contain a key"projectile-root-bottom-up-/tmp/projectile-project"with value"/tmp/first_project". This will stopprojectile-find-filefrom workingas it can't cd to /tmp/first_project.
Instead, we enforce that the string from
projectile-project-rootpoints to a directory that currently exists.