Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit .dir-locals.el file of a project. #944

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Edit .dir-locals.el file of a project. #944

merged 1 commit into from
Jan 20, 2016

Conversation

akermu
Copy link
Contributor

@akermu akermu commented Jan 10, 2016

Add a command `projectile-edit-dir-locals' to quickly edit or create a
.dir-locals.el file for the project.

@bbatsov
Copy link
Owner

bbatsov commented Jan 15, 2016

Such functionality should definitely be part of the readme.

@@ -2640,6 +2640,41 @@ is chosen."

(projectile-commander-bindings)

(defun projectile-skel-read-variable ()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is used in the skeleton below, but it can be used generally, so i should probably rename it.

@bbatsov
Copy link
Owner

bbatsov commented Jan 15, 2016

The commit message's title should not end with a ..

Add a command `projectile-edit-dir-locals' to quickly edit or create a
.dir-locals.el file for the project.
@akermu
Copy link
Contributor Author

akermu commented Jan 18, 2016

I updated the PR, thanks for the review!

bbatsov added a commit that referenced this pull request Jan 20, 2016
Edit .dir-locals.el file of a project
@bbatsov bbatsov merged commit 8c6b4b4 into bbatsov:master Jan 20, 2016
@bbatsov
Copy link
Owner

bbatsov commented Jan 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants