Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'project-file as category metadata in completing read #1903

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

juergenhoetzel
Copy link
Contributor

@juergenhoetzel juergenhoetzel commented Sep 1, 2024

project-file is a more suitable category for the completion (also used by project.el).

'vertico-prescient-completion-category-overrides changes the completion style for 'file to '(basic partial-completion) and limits completion to prefix matches.

Fixes #1902


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

project-file is a more suitable category for the completion (also used
by project.el).

'vertico-prescient-completion-category-overrides changes the
completion style for 'file to '(basic partial-completion) and
limits completion to prefix matches.

Fixes bbatsov#1902
@bbatsov bbatsov merged commit 002e527 into bbatsov:master Sep 1, 2024
7 checks passed
@bbatsov
Copy link
Owner

bbatsov commented Sep 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

projectile-find-file behavior deteriorated in combination with vertico-prescient as of fb78b79
2 participants