Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python PEP621/PEP5128 support #1821

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Conversation

paquiteau
Copy link
Contributor

@paquiteau paquiteau commented Feb 18, 2023

Hi there,

This PR add support for PEP621 python projects, by detecting the standardized pyproject.toml file.

I must admit that I am not confortable with the eldev test framework, and I could not find out if and how i could write a test for this new setup.

Thank you for all the work on this essential package.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • [ ] You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • [ ] You've updated the readme (if adding/changing user-visible functionality)

Thanks!

Detect python project with only pyproject.toml file as project file.
@bbatsov
Copy link
Owner

bbatsov commented Feb 18, 2023

I must admit that I am not confortable with the eldev test framework, and I could not find out if and how i could write a test for this new setup.

No worries, we don't have much tests about the project detection anyways.

@paquiteau paquiteau marked this pull request as ready for review February 18, 2023 09:46
@paquiteau
Copy link
Contributor Author

Nice,
Tell me if anything more is required before merging :)

@bbatsov bbatsov merged commit 047c2a4 into bbatsov:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants