Add a projectile-root-marked function for finding roots #1812
Conversation
Prioritizes .projectile above other bottom-up root files. Related to bbatsov#1810.
Introduces a variable, `projectile-dirconfig-file` specifying the name of the file used by Projectile to explicitly mark project roots. The default is “.projectile”. One use case for this is if you group project-local configs in an XDG-style location. E.g., setting it to “.config/projectile”.
sellout
force-pushed
the
projectile-marker
branch
from
423db72
to
28964f2
Compare
|
Here’s the fix, @Thisch. |
|
The proposed changes look good to me. Thanks! P.S. This should probably be mentioned in the docs as well, but I'll do this myself. |
| @@ -7,6 +7,7 @@ | |||
| * [#1591](https://github.com/bbatsov/projectile/issues/1591): Add `project.el` integration that will make Projectile the default provider for project lookup. | |||
| * Add new command `projectile-find-references` (bound to `C-c C-p ?` and `C-c C-p s x`). | |||
| * [#1737](https://github.com/bbatsov/projectile/pull/1737): Add helpers for `dir-local-variables` for 3rd party use. Functions `projectile-add-dir-local-variable` and `projectile-delete-dir-local-variable` wrap their built-in counterparts. They always use `.dir-locals.el` from the root of the current Projectile project. | |||
| * Add a new defcustom (`projectile-dirconfig-file`) controlling the name of the file used as Projectile’s root marker and configuration file. | |||
|
|
|||
There was a problem hiding this comment.
Shouln't the new projectile-root-marked function be mentioned in the changelog as well?
There was a problem hiding this comment.
Yeah, it should. Those things should also be covered somewhere in the docs, so it's easier to discover but I'll do this myself when I can.
|
This part of the docs definitely needs love, but at least it reminded me why we have
I guess it's for those situations where it's common to have nested projects, although as the markers are essentially the same as for the other function there's little point is having them together in the |
Prioritizes .projectile above other bottom-up root files.
Also makes the name of .projectile customizable.
Related to #1810.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)M-x checkdocwarningsThanks!