Enhance go project detection by referring to go.mod file #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue encountered when working in a go project that doesn't have any
.go
files at the root. The fix is to check for ago.mod
file at the root of the project, avoiding a recursive descent of the project. Thego.mod
file is new-ish and will be present in projects that are using Go modules. The file will be present in all (or almost all) Go projects when Go 1.13 is released later this year.I didn't add any tests, but this is the fix I applied to my local install of projectile and it worked great.
Feel free to remove or tweak my Changelog entry, this change may not be big enough to warrant documentation.
make test
)M-x checkdoc
warnings