Add a new defcustom to configure projectile-kill-buffers. #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 options are implemented: - all-buffers (corresponds to the existing behavior) - keep-processes - kill-only-files: kill only the buffer that have a buffer-file-name. * projectile-kill-buffers-filter: new defcustom.
bbatsov
reviewed
Oct 20, 2018
projectile.el
Outdated
| associated to a file." | ||
| :group 'projectile | ||
| :type '(radio | ||
| (const :tag "All project files" kill-all) |
bbatsov
reviewed
Oct 20, 2018
projectile.el
Outdated
| :group 'projectile | ||
| :type '(radio | ||
| (const :tag "All project files" kill-all) | ||
| (const :tag "Preserve process buffer" keep-processes) |
There was a problem hiding this comment.
I don't get what's the difference between the final two options - keep-processes and and kill-only-files are more or less the same as something's either a file buffer or some special buffer (although those won't necessary have process attached to them).
There was a problem hiding this comment.
You are probably right that the difference may not make much sense in terms of usage. I made the customization point extensible to allow for more fine-grained control, while removing the keep-processes choice.
bbatsov
reviewed
Oct 20, 2018
projectile.el
Outdated
| ;; we take care not to kill indirect buffers directly | ||
| ;; as we might encounter them after their base buffers are killed | ||
| (not (buffer-base-buffer buffer)) | ||
| (case projectile-kill-buffers-filter |
There was a problem hiding this comment.
You probably meant to use pcase here.
mookid
force-pushed
the
kill-buffers-custom
branch
from
937cee6
to
e28f626
Compare
|
Thanks so much for this! Can't wait for it to be merged |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32 options are implemented:keep-processeschangelog:
Note:
edit: eventually kept only
kill-only-files, while allowing any predicate to be used.cc @mfiano
fix #1233