Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return nil for undefined commands #1268

Closed
wants to merge 2 commits into from

Conversation

velimir
Copy link

@velimir velimir commented Aug 17, 2018

revert behaviour introduced in /pull/1255

Seems like it broke compile command for all projects w/o :compilation-dir defined. At least for me on attempt to compile project, command fails with a message:

user-error: The value for: compilation-dir in project-type: rebar was neither a function nor a string.

projectile-compilation-dir function has a fallback to projectile-project-root as a default compilation directory, but new behaviour of projectile-default-generic-command throws an error on attempt to a get command-type from a hash, which is not defined for some project type (most of them).

@velimir
Copy link
Author

velimir commented Aug 17, 2018

/bin/sh: 1: cask: not found
cask install
make: cask: Command not found
make: *** [elpa] Error 127

🤔

@velimir velimir mentioned this pull request Aug 17, 2018
4 tasks
@bbatsov
Copy link
Owner

bbatsov commented Aug 21, 2018

Closing if favour of #1269.

@bbatsov bbatsov closed this Aug 21, 2018
@velimir velimir deleted the generic-command-nil branch August 21, 2018 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants