return nil for undefined commands #1268
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert behaviour introduced in /pull/1255
Seems like it broke compile command for all projects w/o
:compilation-dir
defined. At least for me on attempt to compile project, command fails with a message:projectile-compilation-dir
function has a fallback toprojectile-project-root
as a default compilation directory, but new behaviour ofprojectile-default-generic-command
throws an error on attempt to a get command-type from a hash, which is not defined for some project type (most of them).