Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `nix' project type #1159

Merged
merged 1 commit into from
Sep 17, 2017
Merged

Add `nix' project type #1159

merged 1 commit into from
Sep 17, 2017

Conversation

matthewbauer
Copy link
Contributor

@matthewbauer matthewbauer commented Aug 9, 2017

I've been using this personally for a while but I think it makes sense to go in Projectile. This just registers "nix" projects as anything containing a "default.nix" file. "nix-build" actually both compiles and tests (if doCheck=true), should it be set for both?

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@bbatsov
Copy link
Owner

bbatsov commented Aug 10, 2017

"nix-build" actually both compiles and tests (if doCheck=true), should it be set for both?

I'd say - yes.

You should also mention this in the changelog.

@matthewbauer
Copy link
Contributor Author

Ok, looks like it's mergeable now. /cc @bbatsov

I've been using this personally for a while but I think it makes sense to go in
Projectile. This just registers "nix" projects as anything containing a
"default.nix" file. "nix-build" is set for both testing and compiling (it does both).
@bbatsov bbatsov merged commit ccb185c into bbatsov:master Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants