Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCS submodules brought in even thought not descendent of project root #952

Closed
timcharper opened this issue Jan 22, 2016 · 0 comments
Closed

VCS submodules brought in even thought not descendent of project root #952

timcharper opened this issue Jan 22, 2016 · 0 comments

Comments

@timcharper
Copy link
Contributor

Given the following tree structure:

./.git # git repo top-level
./front-end/
./front-end/.projectile
./front-end/src/...
./server/
./server/vendor
./server/vendor/a-git-submodule/
./server/vendor/a-git-submodule/.git

If the current top-level folder is ./front-end/, and you invoke projectile-find-file, then ../server/vendor/a-git-submodule/ will leak into your choices. Presently, all submodules for the current repository are traversed, recursively so, regardless of whether or not those submodules reside within the current project root.
timcharper added a commit to timcharper/projectile that referenced this issue Jan 22, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
aa688b7
@timcharper timcharper changed the title VCS submodules brought in even thought not descendent of project root [Fix #952] Exclude out-of-project VCS submodules Jan 22, 2016
@timcharper timcharper changed the title [Fix #952] Exclude out-of-project VCS submodules VCS submodules brought in even thought not descendent of project root Jan 22, 2016
timcharper added a commit to timcharper/projectile that referenced this issue Jan 22, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
a4765fe
timcharper added a commit to timcharper/projectile that referenced this issue Jan 22, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
020d920
timcharper added a commit to timcharper/projectile that referenced this issue Jan 22, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
b405564
timcharper added a commit to timcharper/projectile that referenced this issue Jan 24, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
5f5d688
timcharper added a commit to timcharper/projectile that referenced this issue Feb 3, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
eb984b6
timcharper added a commit to timcharper/projectile that referenced this issue Feb 3, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
e9dca5a
timcharper added a commit to timcharper/projectile that referenced this issue Feb 4, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
16d5c92
timcharper added a commit to timcharper/projectile that referenced this issue Feb 4, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
79d465c
timcharper added a commit to timcharper/projectile that referenced this issue Feb 4, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
13319f0
timcharper added a commit to timcharper/projectile that referenced this issue Feb 4, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
9c18ad3
timcharper added a commit to timcharper/projectile that referenced this issue Feb 10, 2016
@timcharper
[Fix bbatsov#952] Exclude out-of-project VCS submodules
6901910
bbatsov added a commit that referenced this issue Feb 10, 2016
@bbatsov
Merge pull request #860 from timcharper/master
677a897 
[Fix #952] Exclude out-of-project VCS submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timcharper