Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectile-ag: ignores not in effect #1514

Closed
outergod opened this issue Apr 7, 2020 · 3 comments · Fixed by #1700
Closed

projectile-ag: ignores not in effect #1514

outergod opened this issue Apr 7, 2020 · 3 comments · Fixed by #1700

Comments

@outergod
Copy link

outergod commented Apr 7, 2020

Expected behavior

Running projectile-ag honors projectile-globally-ignored-directories and projectile-globally-ignored-files, so that affected files and directories don't turn up in the resulting ag query.

Actual behavior

ag is run without any --ignore parameters set and ignored files and directories turn up.

Looking at the code, it's obvious that while ag-ignore-list is being bound in projectile-ag, it's not passed down to (funcall ag-command search-term (projectile-project-root))).

Steps to reproduce the problem

  1. mkdir foo; cd foo; git init; mkdir node_modules; echo bar > node_modules/baz
  2. (add-to-list 'projectile-globally-ignored-directories "node_modules")
  3. M-x projectile-ag RET bar RET

Environment & Version information

Projectile version information

Projectile 2.0.0

Emacs version

GNU Emacs 26.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.13) of 2019-12-10

Operating system

Fedora 31 Silverblue x86_64

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the Stale label Oct 4, 2020
@outergod
Copy link
Author

outergod commented Oct 4, 2020

This is still an issue, unchanged.

@bbatsov
Copy link
Owner

bbatsov commented Dec 2, 2020

Yeah, it'd be nice to improve this. The required changes are pretty simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants