Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WireGuard VPN #77

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

MarcLandis
Copy link
Contributor

  • added Lua service for wireguard endpoint
  • updated Grafana dashboard

@bb-Ricardo
Copy link
Owner

Hi,

Thank you for this great idea. I wanted to implement this as well but was waiting for 7.50.

I would suggest 2 changes:

  • instead of renaming the values it would be great to add the vpn type as a tag and use the value name for both services. Then old dashboard won't break and it can easily be added to new ones.
  • when exporting the dashboard it is important to have the top row unfolded and all other rows folded. This way the changes in the dashboard are kept to the bare minimum. (It is quite silly how the rows are implemented in the json schema but 🤷‍♂️)

Would this be possible?

Thank you.

@MarcLandis
Copy link
Contributor Author

Hi,

I will try to change it to your idea. Unfortunately I am not sure how to add a static tag in lua_services.append(...)

@bb-Ricardo
Copy link
Owner

Line 203 in your PR is a tag function which returns a dict with tags: , "vpntype": "Wireguard"

This tag needs to be added and where it's missing you just need to add the whole tag_function.

@MarcLandis
Copy link
Contributor Author

The updated commit should do it.

P.S.: I just noticed that you are from Berlin too.

@bb-Ricardo
Copy link
Owner

Thank you, will have a look later this week.

@bb-Ricardo bb-Ricardo added this to the 1.2.0 milestone Dec 1, 2022
@bb-Ricardo
Copy link
Owner

Hi,

yes, also from Berlin 😄

Just adding this PR

@bb-Ricardo bb-Ricardo merged commit 4186d5d into bb-Ricardo:next-release Dec 1, 2022
bb-Ricardo added a commit that referenced this pull request Dec 2, 2022
@MarcLandis MarcLandis deleted the wireguard branch December 2, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants