Save MIDI Channel assignments to tuning slots #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KohlJary
force-pushed
the
feature/kj/change-midi-channel
branch
from
039b46f
to
fa66612
Compare
|
I'm back, free from actual work for a bit.
I'll take a look this weekend!
…-Basil
On Wed, Sep 13, 2023 at 9:16 PM KohlJary ***@***.***> wrote:
@KohlJary <https://github.com/KohlJary> requested your review on: #116
<#116> Save MIDI Channel
assignments to tuning slots as a code owner.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AX5QOH6523B332FUK5GXPY3X2KALFANCNFSM6AAAAAA4XOO7AU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Let me know if there are further tweaks to make, was thinking it might make sense to load whatever the config values for the midi channels are set to when loading the preset tunings for instance. If the amount of space taken up in the EEPROM for having the channel assignments saved per preset is too much, could instead use a system wide setting only. I just know I could see utility in being able to assign channels per preset for my own setup. |
|
And if there's anything else you could use help with in maintaining/improving this project, please don't hesitate to reach out. Been meaning to enhance my C++ knowledge anyways and this is a neat project to do that with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #114
Implemented changing the midi channel for each string and saving that information down in the user tuning slots. Could also be an instrument level setting, would just have to move the menu up out of the tuning section, but figured being able to save the channel layout to a preset slot would mean you could have multiple sample sets/synth multipatches set up and be able to switch between them relatively on the fly.