Skip to content

5.0.0

  • 5.0.0
  • cb950f5

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
  • Compare
    Choose a tag to compare
5.0.0: Replace zipper with singlejar (#1463)
  • 5.0.0
  • cb950f5
  • Compare
    Choose a tag to compare

  • Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
@simuons simuons tagged this 20 Jan 08:55 
* Replace zipper with singlejar

Remove zipper from common attributes

singlejar is already there and can generate jars with resources

Looking at bazel source code `singlejar` utility is used for:
* [pack_sources](https://github.com/bazelbuild/bazel/blob/455454a56e961affb041a1d4a9214f7f313a05aa/src/main/java/com/google/devtools/build/lib/rules/java/JavaInfoBuildHelper.java#L198)
* [resources_jar](https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/rules/java/ResourceJarActionBuilder.java#L123)

Motivation:

* use precompiled binaries ie singlejar comes precompiled via remote_java_tools while zipper is built from sources (at least in remote execution)
* use single tool to accomplish same goal

* Fix //test/jmh:Run__test_jmh_test_jmh_jdk11  by specifying correct jdk version instead of system default
Assets 2
Loading