[WIP] see what happens if we drop scala attribute #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've marked this as ready for review to trigger travis (for some reason it doesn't work on draft PRs). |
ittaiz
changed the title
johnynek
reviewed
Nov 4, 2019
| @@ -127,7 +127,6 @@ def _lib( | |||
| jars_to_labels = jars.jars2labels, | |||
| providers = [outputs.merged_provider, jars.jars2labels] + outputs.coverage.providers, | |||
| runfiles = runfiles, | |||
| scala = scalaattr, | |||
There was a problem hiding this comment.
Note above where we construct scalaattr: can we remove that? Indeed can we grep for all calls to create_scala_provider and make sure we aren’t calling that function or that it can be refactored to return a JavaInfo?
|
This is exciting as it removes some of the oldest cruft in the rules. Thank you! |
|
The failures are in the bazel run pre 1.1.0 so we're good |
|
:) indeed.
Re the scala attribute creation and such- definitely, you know I don’t
leave garbage behind. I was just trying to understand how much heavy
lifting is required.
…On Mon, 4 Nov 2019 at 17:34 P. Oscar Boykin ***@***.***> wrote:
This is exciting as it removes some of the oldest cruft in the rules.
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#869?email_source=notifications&email_token=AAKQQFZCFTHME23O5A7X35TQSA6IDA5CNFSM4JIRHOO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC7VCXQ#issuecomment-549409118>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKQQFZGE6P2XOUGKRV5CETQSA6IDANCNFSM4JIRHOOQ>
.
|
ittaiz
force-pushed
the
ittaiz-patch-3
branch
from
a708d1f to
7318e45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking impact of dropping scala attribute
Motivation
Bazel is going to drop the sturct/attribute syntax (bazelbuild/bazel#9014)
We need to understand the impact of dropping the scala attribute.
One thing is that this requires Bazel 1.1.0 due to both junit and IJ import needing this fix bazelbuild/bazel#8916