Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version-aware naming for scala_compiler_source repository #1560

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

aszady
Copy link
Contributor

@aszady aszady commented Mar 26, 2024

Description

A small preparation for multiple SCALA_VERSIONS.

In theory breaking, as removes @scala_compiler_source repository.
But I guess it's too internal to anyone depend on it.

Motivation

Originally #1290.
Partitioned from #1552.

A small preparation for multiple `SCALA_VERSIONS`.
@aszady
Copy link
Contributor Author

aszady commented Apr 8, 2024

Hi @simuons, @liucijus,
can we do anything to help you reviewing these PRs regarding cross-build support?
Note that all open PRs are independent of each other and could be reviewed/merged in any order.

@simuons
Copy link
Collaborator

simuons commented Apr 8, 2024

Hi @aszady, sorry last week I was on vacation and could not get over your PRs. I'm looking at them now and will answer today/tomorrow.

@simuons
Copy link
Collaborator

simuons commented Apr 22, 2024

Hi, @aszady, could you confirm this is still relevant? I mean in another PR you mentioned that direction you are taking is to have single label with select. This doesn't apply here?

@aszady
Copy link
Contributor Author

aszady commented Apr 22, 2024

Yes; I think the general convention should be like:

Toolchains with config transitions seem to nicely join these two worlds together.

Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aszady

@liucijus liucijus merged commit d83ba31 into bazelbuild:master Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants