Build with JDK 21 #1556
Merged
Build with JDK 21 #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liucijus
reviewed
Mar 25, 2024
test/BUILD
Outdated
Comment on lines
779
to
794
| #scala_library( | ||
| # name = "JunitRuntimePlatform", | ||
| # srcs = [ | ||
| # "src/main/scala/scalarules/test/junit/runtime_platform/JunitRuntimePlatformTest.java", | ||
| # ], | ||
| # deps = ["@io_bazel_rules_scala_junit_junit"], | ||
| #) | ||
| # | ||
| #scala_junit_test( | ||
| # name = "JunitRuntimePlatform_test_runner", | ||
| # size = "small", | ||
| # runtime_jdk = "@bazel_tools//tools/jdk:remote_jdk11", | ||
| # suffixes = ["Test"], | ||
| # tests_from = [":JunitRuntimePlatform"], | ||
| # runtime_deps = [":JunitRuntimePlatform"], | ||
| #) |
There was a problem hiding this comment.
@simuons are these accidentally commented out, or is there a reason? If there's a reason, please leave a comment in the code.
There was a problem hiding this comment.
@liucijus thanks for noting. I forgot about it.
There was a problem hiding this comment.
@liucijus fixed test for jdk > 11. Please take a look.
Add -Djava.security.manager=allow jvm flag to: - tools executed via ctx.actions.run if host jdk is >= 17 - generated test executables if target jdk is >= 17
Make sure compilation toolchain matches runtime target version This test was failing with --java_language_version=21 Because it got compiled with newer jdk than was run.
simuons
force-pushed
the
build-with-jdk-21
branch
from
a9aaa79 to
3233a86
Compare
liucijus
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codebase doesn't build with jdk 21 with default settings.
Issue is that workers and test runners use SecurityManager which fails at runtime.
Fix is to conditionally add -Djava.security.manager=allow jvm flag to:
This change involves some kind of guessing with which jdk version worker will be run.
JDK is linked into worker/executable runfiles and it matches host jdk (hence added _java_host_runtime attribute to all relevant rules)
Added separate build for jdk 21