Make scala_proto_aspect have "provides = [ScalaProtoAspectInfo]" #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI is failing. While I can reproduce the same error locally on a MacBook, I get the same errors on the current master branch. |
simuons
approved these changes
Mar 25, 2024
timothyg-stripe
force-pushed
the
patch-1
branch
from
fd2480c to
cfe5984
Compare
liucijus
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
provides = [ScalaProtoAspectInfo]toscala_proto_aspect.Motivation
scala_proto_aspectalways returns aScalaProtoAspectInfoprovider, so there's no reason why the provider is not listed in theaspect(provides=[…])list. Crucially, havingprovides = [ScalaProtoAspectInfo]enables aspect-on-aspect, allowing a second aspect to inspect the result ofscala_proto_aspect.