Don't output unused dependency messages when compilation fails #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @laurynaslubys! I think build status also needs to be reflected in produced |
…ils. When a scala source is malformed, the AST parsing dependency checking step comes back with no/very little dependencies used. It then prints out a bunch of these warnings which are not necessarily true. As a workaround, let's not print the unused dependency warnings if the build has already failed before hand.
laurynaslubys
force-pushed
the
quiet-warnings
branch
from
581c05b to
d3674f0
Compare
|
Good point. I've updated this so we pretend that there are no unused dependencies if the reporter has errors already. |
simuons
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a scala source is malformed, the AST parsing dependency checking step comes back with no/very little dependencies used. It then prints out a bunch of these warnings which are not necessarily true. As a workaround, let's not print the unused dependency warnings if the build has already failed before hand.
Motivation
The printed warnings are potentially misleading and therefore should not be printed.