Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scala 3.3 LTS #1501

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Add support for Scala 3.3 LTS #1501

merged 3 commits into from
Jun 16, 2023

Conversation

csubj
Copy link
Contributor

@csubj csubj commented May 31, 2023

Description

Add support for Scala 3.3.0

  • Add the build and repository definitions for Scala 3.3.0
  • Add an extra set of tests for Scala 3.3.0

Motivation

  • To stay as close as possible to the head of Scala and to provide a base for LTS.
  • To make new features in Scala 3.3 available to developers.

Followed the steps of #1465 and the changes pass those tests but I think it's probably not exhaustive nor complete. I computed the dep SHA256 with a tool I hacked together and updated the values. If people are interested I can make my tool a bit more complete for managing and updating the artifact dict and publish it somewhere.

@csubj csubj requested review from liucijus and simuons as code owners May 31, 2023 15:37
@csubj
Copy link
Contributor Author

csubj commented Jun 2, 2023

I'm not sure I have the ability to re-run the build but I believe the failure is unrelated to changes, perhaps someone can give it a kick for me

Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @csubj. Please address my comment

third_party/repositories/scala_3_3.bzl Outdated Show resolved Hide resolved
@csubj csubj requested a review from liucijus June 5, 2023 15:10
@erinmez
Copy link

erinmez commented Jun 15, 2023

poke, bump :) would also love to see this find its way into the master

@simuons simuons merged commit 12d60d2 into bazelbuild:master Jun 16, 2023
@csubj csubj deleted the scala3.3.0 branch June 16, 2023 16:51
@aaylward
Copy link

@csubj Thanks for adding this! Does scalatest-compatible work for you with scala 3.3? I get a sha256 mismatch:

Checksum was 9283e684d401d821a4cbb2646f9611cbbcd7828d2499483d13a4b507775a4cd7 but 
wanted 7e5f1193af2fd88c432c4b80ce3641e4b1d062f421d8a0fcc43af9a19bb7c2eb

The 928... checksum is what I see when I do

wget https://maven-central.storage-download.googleapis.com/maven2/org/scalatest/scalatest-compatible/3.2.16/scalatest-compatible-3.2.16.jar
shasum -a 256 scalatest-compatible-3.2.16.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants