cargo_build_script: add some tests for the cc_args_and_env processing #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
#2931 added tests for _pwd_flags, however the test as-is passes with #2911 and #2922, which still caused problems and reverted. Here I introduce a test case for likely unfixed in reverted #2925. The test needs strictter check for cflags. As-ls `flag in cflags` is a just substring search and very weak test for abs path. For #2917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #2917: add some cargo_build_script regression tests for the cc_toolchain processing.