-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove internal usage of deprecated py_binary ad py_test #2569
chore: remove internal usage of deprecated py_binary ad py_test #2569
Conversation
This is also deprecating the symbols in the If we want to start printing deprecation messages in Maybe the I ran out of time today, so that is it for today. |
This now only warns if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits/style, otherwise LGTM
This is great, thank you! I didn't realized I missed so many other spots, sorry about that. re: deprecating pythons_hub symbols: Yes, deprecating those also makes sense re: move deprecation helper elsewhere: yes, I agree re: environment variable: Thanks for creating this. I like this idea a lot. |
addendum: I've approved, but not queued for merge, in case you want to move with_deprecated elsewhere before merging. I'm OK with that being done in a separate PR, too. |
OK, extra changes that I needed to do:
I think this makes the change much more robust and we have a single place for the deprecated symbols. If we wanted we could add a |
This goes together with #2565 to remove the internal usage of the deprecated
symbols. This also fixes the compile_pip_requirements symbol to print the
correct deprecation message.
Builds on top of 611eda8
The example message that would be printed is as follows: