fix: py_proto_library: external runfiles #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpudlik
force-pushed
the
legacy_external_runfiles
branch
3 times, most recently
from
5e31d8f to
b83c3e6
Compare
Previously, the import path within the runfiles was only correct for the case --legacy_external_runfiles=True (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. Fixes bazelbuild#2515. Added a regression test, and tested locally against the minimal reproducer in that issue.
tpudlik
force-pushed
the
legacy_external_runfiles
branch
from
b83c3e6 to
929df99
Compare
aignas
approved these changes
Dec 22, 2024
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Feb 1, 2025
Previously, the import path within the runfiles was only correct for the case `--legacy_external_runfiles=True` (which copied the runfiles into `$RUNFILES/<main repo>/external/<external repo>/<path>` in addition to `$RUNFILES/<external repo>/<path>`. This flag was flipped to False in Bazel 8.0.0. This is identical to the change made to rules_python in bazelbuild/rules_python#2516. Work towards bazelbuild/rules_python#2581. PiperOrigin-RevId: 721941173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the import path within the runfiles was only correct for the case --legacy_external_runfiles=True (which copied the runfiles into
$RUNFILES/<main repo>/external/<external repo>/<path>in addition to$RUNFILES/<external repo>/<path>. This flag was flipped to False in Bazel 8.0.0.Fixes #2515.
Tested locally against the minimal reproducer in that issue.