-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pyproject.toml in compile_pip_requirements #1519
Conversation
8454c1c
to
dff8198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think in the description, could be worth clarifying that it's support PEP-621 project.dependencies
https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#declaring-project-metadata only. It shouldn't imply support of any other TOML tables that may exist, or tool specific tables such as tool.black
or tool.poetry
etc
LGTM. I pushed a small update to the The only comment, more question, I have is: should src default to |
e31955a
to
b746642
Compare
I have changed the code to default to If you are OK with the changes, explanation, feel free to merge it during your working hours. |
With this PR we can also use
pyproject.toml
in additionto
requirements.in
which helps in making the requirementsin a more structured form. For example, we could parse the
toml itself and create aliases in the hub repos only for the
packages outlined in the
pyproject.toml
file. The same forgazelle
, we could restrictgazelle_python.yaml
contentsto only the dependencies listed in
pyproject.toml
.Examples can be migrated once we agree on the interface.
Summary: