Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No docs for 0.9 versions #716

Closed
alexeagle opened this issue Jul 13, 2023 · 14 comments
Closed

No docs for 0.9 versions #716

alexeagle opened this issue Jul 13, 2023 · 14 comments

Comments

@alexeagle
Copy link
Collaborator

https://github.com/bazelbuild/rules_pkg/blob/main/docs/latest.md documents 0.8.2

Is this a manual process on releases?

@aiuto
Copy link
Collaborator

aiuto commented Aug 22, 2023

It's manual. I have not found the time payoff in automating it robustly.

Doing 'latest' is easy, or not, depending on what we consider latest to mean.
I've been treating it as head, but the issue description might imply you take it to mean latest release.

The versioned releases are their own question. I don't think having a distinct text for every release adds value. It encourages web search to find obsolete docs. OTOH, some people do want the docs for the specific thing they are using.

Anyway, #739 and #740 are out to do some updates.

@alexeagle
Copy link
Collaborator Author

I'd like to fix this permanently to reduce the maintenance burden in this repo. I have the time to automate it robustly.

https://github.com/bazel-contrib/rules-template/tree/main/docs is the pattern used in a dozen rulesets. It's just a regular test that asserts the markdown at HEAD always matches the stardoc output at HEAD. Every PR updates the docs.
Users can use the GitHub UI to read docs at any tag they choose.

Can I send you a PR for this, rather than a special effort for 0.9? I think we should cut releases regularly, but the more effort required, the less likely we are to find the time to perform them.

@aiuto
Copy link
Collaborator

aiuto commented Aug 22, 2023 via email

@alexeagle
Copy link
Collaborator Author

There's no post-processing. We can make a unified experience with a table of contents like https://github.com/aspect-build/bazel-lib#public-api
and for bad stardoc generation, I either fix that upstream or use a fork of stardoc with some of my fixes.

Would you like a PR to see what this will look like?

@aiuto
Copy link
Collaborator

aiuto commented Aug 23, 2023 via email

@alexeagle
Copy link
Collaborator Author

Can you point to the stardoc bug? I wonder if it's the dedenting issue that caused me to fork but was recently fixed.

@aiuto
Copy link
Collaborator

aiuto commented Aug 23, 2023

bazelbuild/stardoc#120
bazelbuild/stardoc#118
bazelbuild/stardoc#98

There are probably others.
I'm not sure if the stardoc rule lets me control the order of methods declared, or if it would sort them alphabetically (that would be a new bug).

The non-generated text that I need could be put in the silverlight template.

@alexeagle
Copy link
Collaborator Author

Thanks, I replied to all three of those issues with the techniques we use for Aspect's rulesets. IMHO we do a really nice job providing high-quality, readable API docs for users, without having to invent any mechanisms that live in the ruleset repo to workaround stardoc issues. If you have any time, I'd love to spend 15min walking through that with you.

@alexeagle
Copy link
Collaborator Author

There are docs for 0.9 now, so this is solved as reported. I get the sense that you're not really interested in automating the docs process and don't want to make a big deal out of it.

@aiuto
Copy link
Collaborator

aiuto commented Oct 1, 2023 via email

@alexeagle
Copy link
Collaborator Author

Could I get a contact info from someone there? I'd like to get the Bazel-contrib rules-template that all the community rules are based on

@aiuto
Copy link
Collaborator

aiuto commented Oct 4, 2023 via email

@meisterT
Copy link
Member

meisterT commented Oct 5, 2023

cc @comius @meteorcloudy

@alexeagle
Copy link
Collaborator Author

Probably better to take this to a dedicated issue: bazel-contrib/rules-template#99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants