Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify what the compile_jar value should be when building the library #341

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Specify what the compile_jar value should be when building the library #341

merged 1 commit into from
Sep 30, 2020

Conversation

szinn
Copy link
Contributor

@szinn szinn commented Jun 15, 2020

Resolves issue 340

@szinn
Copy link
Contributor Author

szinn commented Jun 22, 2020

bump

@szinn
Copy link
Contributor Author

szinn commented Jul 28, 2020

bump - can this be reviewed?

@szinn
Copy link
Contributor Author

szinn commented Sep 12, 2020

bump - can this be merged?

@restingbull restingbull merged commit d7d8912 into bazelbuild:master Sep 30, 2020
@szinn szinn mentioned this pull request Feb 13, 2021
Closed
@szinn szinn deleted the scotte-fix-compile-jar-for-library branch February 18, 2021 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@restingbull restingbull restingbull approved these changes

@cgruber cgruber Awaiting requested review from cgruber cgruber is a code owner

@djwhang djwhang Awaiting requested review from djwhang

@jin jin Awaiting requested review from jin

@timpeut timpeut Awaiting requested review from timpeut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szinn @restingbull