Filter non-kotlin code out of generated sources #263
Conversation
justhecuke-zz
requested review from
cgruber,
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
|
Any way to get someone to take a quick look? It's a very minor change that unblocks usage of some annotation processors. |
src/main/kotlin/io/bazel/kotlin/builder/tasks/jvm/KotlinJvmTaskExecutor.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks right, but I'd like a quick nod from @restingbull because he's also working on perf improvements, and I want to make sure he's seeing this.
cgruber
added
component: android
component: jvm
P2
status: in review
I'm in the process of adding tests. It's a bit more involved than I thought it would be. |
I added a unit test although I had to change the visibility of some methods to get everything working. I can also make a simple java plugin that generates a non-jvm file and make a E2E test of the kotlin compilation rules, but I wasn't sure if that was something that would be OK. |
|
@cgruber @restingbull I think this can be reviewed again. |
|
@cgruber friendly ping since the last one I gave was late on a friday. |
|
@cgruber is unavailable at the moment. I'll squash and merge. |
|
Thanks. |
|
Sorry for the dead air @justhecuke - was travelling. Thanks for picking up the slack @restingbull |
* Filter non-kotlin code out of generated sources * Single-pass filter and vague android sdk * Add test for filtering generated source files
* upstream/master: Fix non-reproducible archives (bazelbuild#304) Adds a kt_plugin rule (bazelbuild#308) Ensure that KotlionBuilder workers use a clean directory for each compilation. (bazelbuild#298) Apply autoformatting to all files. (bazelbuild#302) Optional outputs (bazelbuild#291) Change plugins to use depsets, as opposed to lists. (bazelbuild#292) Add Corbin to the codeowners. (bazelbuild#293) Update Protobuf to 3.11.3 (bazelbuild#286) Remove tree artifacts (bazelbuild#287) Cleanup src tree (bazelbuild#288) Update README.md (bazelbuild#285) Filter non-kotlin code out of generated sources (bazelbuild#263) Update readme so the dev instructions highlight using a local clone (bazelbuild#283) Remove third_party checked in jars, and properly pull maven dependencies. (bazelbuild#279) Only propagate srcjar if it isn't the default empty jar added in ae70089 to fix bazelbuild/intellij#1616 (bazelbuild#276) Allow resources to be in a kotlin directory (bazelbuild#268)
* Filter non-kotlin code out of generated sources * Single-pass filter and vague android sdk * Add test for filtering generated source files
Filters out non-JVM generated sources.
Annotation processors (like dagger) can generate non-JVM code (like
.dotfiles) and this can cause an IllegalStateException due to having a non-JVM source file.Since we cannot expect all annotation processors to only generate JVM source code, and to be generally useful for generic annotation processors, we need to gracefully handle generated non-JVM code rather than having a strict requirement that only JVM code can be generated since that would probably preclude the use of many useful annotation processors.
Also, added a print of errors hit during compilation. Before it would simply error out mysteriously with no error message. Now, we will actually get the error message. It was very helpful in debugging this particular issue.