Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out external workspace versions and SHA256s into variables #259

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

cgruber
Copy link
Collaborator

@cgruber cgruber commented Jan 15, 2020

No description provided.

@cgruber cgruber added component: common P2 type: cleanup Refactorings, idiomatic transforms, tech debt payoff status: in review Solution being reviewed labels Jan 15, 2020
@cgruber cgruber self-assigned this Jan 15, 2020
@cgruber cgruber merged commit 4512a83 into bazelbuild:master Jan 17, 2020
@cgruber cgruber deleted the factor_out_workspace_versions branch January 17, 2020 00:16
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
* upstream/master:
  typo and add missing paren.
  Add release legacy-1.3.0
  Reference proper "current release" as legacy 1.3.0
  Update README to account for legacy-1.3.0 release.
  Fix bad date in changelog
  Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271)
  Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272)
  Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259)
  Add a link to the generated documentation (bazelbuild#237)
  Stop using native java rules (bazelbuild#258)
  Add InteliiJ aspect info (bazelbuild#242)
  Change readme file formatting (bazelbuild#243)
  Update CHANGELOG.md
  Update readme to release candidate 4
  Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257)
  Passthrough tags to the container android_library (bazelbuild#255)
  Fix current "latest" to actually be the latest.
  Update CHANGELOG.md
  Update to release legacy-1.3.0-rc3
  Support more recent java versions in the kotlin toolchain. (bazelbuild#236)
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
…m_upstream

* upstream/master:
  typo and add missing paren.
  Add release legacy-1.3.0
  Reference proper "current release" as legacy 1.3.0
  Update README to account for legacy-1.3.0 release.
  Fix bad date in changelog
  Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271)
  Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272)
  Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259)
  Add a link to the generated documentation (bazelbuild#237)
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: common P2 status: in review Solution being reviewed type: cleanup Refactorings, idiomatic transforms, tech debt payoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants