-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obtain bootstrap class path from dedicated runtime toolchain type #114
Conversation
cb6dfa4
to
46950bb
Compare
@hvadehra Could you review this? It is based on bazelbuild/bazel#18841. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like for @cushon to also have a look
7f94f77
to
58834b4
Compare
@hvadehra @cushon Friendly ping. I pushed a commit to fix CI after the merge of bazelbuild/bazel@8715e9a. Let me know whether you would want me to handle this differently. |
Since bazelbuild#114, rules_java requires a version of Bazel that contains bazelbuild/bazel@8715e9a
f26cfa6
to
6b04a31
Compare
Had to push another commit to fix a breakage that CI didn't catch: I forgot to add the Do you see a way to have CI catch such issues, for example by including a pipeline that runs Bazel@HEAD with an CC @meteorcloudy in case you have an idea |
I do feel the test coverage for rules_java is quite limited, I think we can:
I would suggest to look into |
This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation. The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android). Work towards #17085 Work towards bazelbuild#64 Split off from #18262
6b04a31
to
0294790
Compare
BEGIN_PUBLIC Copybara import of the project: -- cb82ccb by Fabian Meumertzheim <[email protected]>: Obtain bootstrap class path from dedicated runtime toolchain type This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation. The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android). Work towards #17085 Work towards #64 Split off from #18262 -- ab3c792 by Fabian Meumertzheim <[email protected]>: Register toolchains in MODULE.bazel -- f2218a4 by Fabian Meumertzheim <[email protected]>: Update Bazel to 7.0.0-pre.20230710.5 -- 0294790 by Fabian Meumertzheim <[email protected]>: Add missing WORKSPACE `register_toolchains` calls END_PUBLIC COPYBARA_INTEGRATE_REVIEW=#114 from fmeum:17085-bootstrap-toolchain 0294790 PiperOrigin-RevId: 554446834 Change-Id: I961944be5bfe461528e94c85247f6c36236a561d
*** Reason for rollback *** `bazel_compatibility` does not support pre-release versions We can re-introduce this once bazelbuild/bazel#19189 is fixed *** Original change description *** Copybara Merge: #123 BEGIN_PUBLIC Copybara import of the project: -- 3de49c8 by Fabian Meumertzheim <[email protected]>: Mark rules_java as compatible with Bazel >= 7.0.0-pre.20230710.5 Since #114, rules_java requires a version of Bazel that contains bazelbuild/bazel@8715e9a END_PUBLIC *** PiperOrigin-RevId: 554463780 Change-Id: Ifdbaeb60bce59fdad3bfde8b343ed870d792eba7
@hvadehra I think so, thanks! |
@hvadehra Could you create a release that I can then update Bazel to? |
This decouples the concepts of a Java runtime used to run on the target platform from the Java runtime that provides the bootstrap class path used during compilation.
The former needs constraints on the target platform, whereas the latter should not have any constraints on the target platform to allow for cross-compilation to target platforms for which a JDK runtime is not available (e.g. Android).
Work towards bazelbuild/bazel#17085
Work towards #64
Split off from bazelbuild/bazel#18262