Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip module-info.class from deploy jars #260

Open
fmeum opened this issue Jan 8, 2025 · 0 comments
Open

Strip module-info.class from deploy jars #260

fmeum opened this issue Jan 8, 2025 · 0 comments
Assignees

Comments

@fmeum
Copy link
Contributor

fmeum commented Jan 8, 2025

When a dependency of a java_binary or java_single_jar rule is a module jar (i.e., it contains a module-info.class file), that file leaks into the deploy jar, which incorrectly makes the deploy jar a module jar with that (most likely incorrect) module declaration.

@cushon cushon self-assigned this Jan 8, 2025
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Jan 8, 2025
bazelbuild/rules_java#260

PiperOrigin-RevId: 713312008
Change-Id: Ifaab4668abbf680912ded440e42bafe0cca7ec27
fmeum pushed a commit to fmeum/bazel that referenced this issue Jan 29, 2025
bazelbuild/rules_java#260

PiperOrigin-RevId: 713312008
Change-Id: Ifaab4668abbf680912ded440e42bafe0cca7ec27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants