Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move buildifier to buildkite. #680

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Move buildifier to buildkite. #680

merged 3 commits into from
Jan 31, 2019

Conversation

xingao267
Copy link
Member

And run the latest version of buildiifer in lint=fix mode.

@xingao267
Move buildifier to buildkite.
9781231 
And run the latest version of buildiifer in lint=fix mode.
@xingao267
Copy link
Member Author

The latest commit also fixes one remaining comment from https://github.com/bazelbuild/rules_docker/pull/648/files/eb21e862ef8b7c7a294bd0d9d51c0022d56eeb1a#r247098403

@xingao267
Copy link
Member Author

ptal, according the following refs:

https://docs.bazel.build/versions/master/skylark/performance.html
https://docs.bazel.build/versions/master/skylark/depsets.html
https://docs.bazel.build/versions/master/skylark/lib/globals.html#depset
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#depset-union
bazelbuild/bazel#5817

@xingao267
Copy link
Member Author

hopefully nothing breaks...

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlopezgi, xingao267
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xingao267 xingao267 merged commit 28d52d5 into bazelbuild:master Jan 31, 2019
@xingao267 xingao267 deleted the buildifier branch January 31, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlopezgi nlopezgi nlopezgi approved these changes

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

Assignees

@nlopezgi nlopezgi

Labels
cla: yes lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xingao267 @k8s-ci-robot @nlopezgi @googlebot