Fixing CI #2178
Merged
Fixing CI #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
requested review from
gravypod,
pcj,
smukherj1 and
uhthomas
as code owners
gravypod
reviewed
Nov 6, 2022
gravypod
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
CI is using a unsupported platform ubuntu2104, causing errors like this: https://buildkite.com/bazel/rules-docker-docker/builds/6518#0183f6b9-a939-4a3b-be1b-dffddcb53c1c/107-118
What is the new behavior?
Using ubuntu2004 because the latest ubuntu2204 does not have docker installed. This PR also removed tests that compares digests, because they are change detector tests. This fixed those tests on both Linux and macOS, allowing us to run more tests on macOS
Does this PR introduce a breaking change?
Other information