Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust_image #1950

Closed
wants to merge 1 commit into from
Closed

Fix rust_image #1950

wants to merge 1 commit into from

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Nov 5, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1949

What is the new behavior?

Fixes #1949

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

closes #1949

@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@UebelAndre UebelAndre marked this pull request as ready for review November 5, 2021 15:12
@UebelAndre
Copy link
Contributor Author

This PR is blocked by a series of failures unrelated to the changes here.

================================================================================
==================== Test output for //tests/container:alpine_custom_attr_digest_test:
/private/var/tmp/_bazel_buildkite/f9511fe9dd152becd17d41841444d68d/sandbox/darwin-sandbox/724/execroot/io_bazel_rules_docker/bazel-out/darwin-fastbuild/bin/tests/container/alpine_custom_attr_digest_test.runfiles/io_bazel_rules_docker/tests/container/alpine_custom_attr_digest_test_impl.sh.dat 2021-11-05 15:11:49.000000000 +0000
/private/var/tmp/_bazel_buildkite/f9511fe9dd152becd17d41841444d68d/sandbox/darwin-sandbox/724/execroot/io_bazel_rules_docker/bazel-out/darwin-fastbuild/bin/tests/container/alpine_custom_attr_digest_test.runfiles/io_bazel_rules_docker/tests/container/new_push_test_legacy_from_container_img.digest 2021-11-05 15:11:52.000000000 +0000
@@ -1 +1 @@
-sha256:2f3bf2d061a1bab130cdd98f10b73dfceb08bfbf94a610c62f20c787073e5178
\ No newline at end of file
+sha256:63a40621b30af05f51fb2b38c2b5c56f9cc82cc605d556e09cacdbbdc5adec63
\ No newline at end of file

@gravypod
Copy link
Collaborator

gravypod commented Nov 5, 2021

This change looks good but it looks like some things are failing on mac:

//tests/container:alpine_custom_attr_digest_test
//tests/container:image_test
//tests/container:test_digest_output1

I don't know if your change effects these. Some other users have seen these issues with our CI (hashing failures on some targets). Would you mind trying to debug these to see if they're from your PR?

@UebelAndre
Copy link
Contributor Author

They're not from my PR. The same failure occurs on #1948

@UebelAndre
Copy link
Contributor Author

Deleting in favor of #1951

@UebelAndre UebelAndre closed this Nov 5, 2021
@dfreese
Copy link
Contributor

dfreese commented Nov 5, 2021

Deleting in favor of #1951

Whoops, didn't look to see if this had come up previously!

@UebelAndre
Copy link
Contributor Author

Deleting in favor of #1951

Whoops, didn't look to see if this had come up previously!

All good buddy 😃 just so long as the changes go in, I don't care who's name is on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules Docker no longer works with the latest commit of rules_rust
3 participants