Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag --incompatible_disable_depset_items will break rules_docker in a future Bazel release #1344

Closed
bazel-flag-bot opened this issue Dec 26, 2019 · 0 comments · Fixed by #1480
Closed

Flag --incompatible_disable_depset_items will break rules_docker in a future Bazel release #1344

bazel-flag-bot opened this issue Dec 26, 2019 · 0 comments · Fixed by #1480

Comments

@bazel-flag-bot
Copy link

Incompatible flag --incompatible_disable_depset_items will be enabled by default in a future Bazel release [1], thus breaking rules_docker.

The flag is documented here: bazelbuild/bazel#9017

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything.

If you don't want to receive any future issues for rules_docker or if you have any questions,
please file an issue in https://github.com/bazelbuild/continuous-integration

Important: Please do NOT modify the issue title since that might break our tools.

[1] The target release hasn't been determined yet. Our tool will update the issue title once the flag flip has been scheduled.
@Yexo Yexo mentioned this issue Apr 21, 2020
Merged
alex1545 added a commit that referenced this issue Apr 23, 2020
@Yexo @alex1545
java_files() already returns a depset, don't wrap the return value in (…
d75a992 
…#1480)

another depset. Passing a depset as first argument to the depset
constructor is deprecated.

This fixes #1344 (and duplicate #1333).

Co-authored-by: alex1545 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

java_files() already returns a depset, don't wrap the return value in
1 participant
@bazel-flag-bot