Fix wrong os in xcframework frameworks infoplist #2549
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themz
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
themz
commented
Oct 4, 2024
| @@ -88,13 +96,26 @@ def _platform_prerequisites( | |||
| platform_type_string: The platform type for the current target as a string. | |||
| uses_swift: Boolean value to indicate if this target uses Swift. | |||
| xcode_version_config: The `apple_common.XcodeVersionConfig` provider from the current context. | |||
| environment: "device" or "simulator" environment of the current target. Optional. | |||
|
|
|||
| Returns: | |||
| A struct representing the collected platform information. | |||
| """ | |||
| platform_type_attr = getattr(apple_common.platform_type, platform_type_string) | |||
| platform = apple_fragment.multi_arch_platform(platform_type_attr) | |||
There was a problem hiding this comment.
[review-note]
Here, we don't have an option to determine the correct platform for the simulator, as platform_type can only be ios or tvos, whereas platform for ios can be both ios_simulator and ios_device.
themz
force-pushed
the
2524_fix_wrong_info_plist_platfrom_for_xcframework
branch
from
b26ebca
to
6f31244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue where the Info.plist contains an incorrect value in the xcframework multiplatform bundle.
In this configuration, the Info.plist for x86_64 will contain the 'iphoneos' value for DTPlatformName, but it is supposed to be iphonesimulator.
Related to #2524