fix empty glob() error #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional info:
In the future, we might be able to remove the Someone else experiencing the same issue: https://bazelbuild.slack.com/archives/CD9FZL3KR/p1737971124191359 |
ted-xie
reviewed
Jan 29, 2025
BUILD.ndk_clang.tpl
Outdated
| @@ -49,7 +49,7 @@ filegroup( | |||
| "bin/*", | |||
| "lib64/**/*", | |||
| "lib/**/*", | |||
| ]), | |||
| ], allow_empty = True), | |||
There was a problem hiding this comment.
It would be helpful if you could add a comment either here or line 50 explaining the context: old NDKs had both lib and lib64, new NDKs only have lib.
Could you also run buildifier on this file?
There was a problem hiding this comment.
Thank you for the review!
Doing that 👍
Closed
gdevillele
force-pushed
the
fix_glob_empty_error
branch
from
d00c0a6 to
f07a8fe
Compare
ted-xie
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr : the issue description and repro: https://github.com/gdevillele/debug_bazel
I am trying to build native C libs for Android using Bazel and
rules_android_ndk, and am getting the following error:This is due to a breaking change introduced in Bazel 8.0.
(bazelbuild/bazel#8195)
Note: I am still a beginner with Bazel, so let me know if this is not the correct way of fixing this.
Thank you 🙂