Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: java_tools_javac14-v1.0 release #28

Closed
davido opened this issue Jul 14, 2020 · 6 comments
Closed

release: java_tools_javac14-v1.0 release #28

davido opened this issue Jul 14, 2020 · 6 comments
Assignees

Comments

@davido
Copy link
Contributor

davido commented Jul 14, 2020

Now, that this PR is merged, new java_tools_javac14 release should be conducted.

Cc @philwo.

@philwo
Copy link
Member

philwo commented Jul 23, 2020

I'll have a look at this today.

@philwo philwo self-assigned this Jul 23, 2020
@philwo
Copy link
Member

philwo commented Jul 23, 2020

Buildkite pipeline finished successfully: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/135

I'm about to run these commands now:

$ src/create_java_tools_release.sh --commit_hash fe291f7dcadc20eb85cff07b2cd4d899d79fba71 --java_tools_version 1.0 --java_version 14 --rc 1 --release false
$ src/create_java_tools_release.sh --java_tools_version 1.0 --java_version 14 --rc 1 --release true

@philwo
Copy link
Member

philwo commented Jul 23, 2020

Done:

releases/javac14/v1.0/java_tools_javac14_linux-v1.0.zip 196128eadc68a55fb42a1f990c84ee816f5b29320a72fe542fcfc4206ac3978a
releases/javac14/v1.0/java_tools_javac14_windows-v1.0.zip a6c69fd89b87fccc4c75203be6b407a1ca22cbdb54cffbd445f874281a933149
releases/javac14/v1.0/java_tools_javac14_darwin-v1.0.zip e20f002ceb3f3353d64c022e1f3400d8539ee56ffcfd4a6680d73d6a2cac938b

@davido Can you take it from here?

@philwo
Copy link
Member

philwo commented Jul 23, 2020

Release uploaded to GitHub, too: https://github.com/bazelbuild/java_tools/releases/tag/javac14_v1.0

@davido
Copy link
Contributor Author

davido commented Jul 23, 2020

Thanks, @philwo!

@davido davido closed this as completed Jul 23, 2020
@davido
Copy link
Contributor Author

davido commented Jul 23, 2020

@philwo

Thanks again, it works like a charm see updated java 14 toolchain example repository: [1], and updated gerrit change: [2].

[1] https://github.com/davido/bazel_java_toolchain14/blob/master/WORKSPACE#L4
[2] https://gerrit-review.googlesource.com/c/gerrit/+/269382

davido added a commit to davido/bazel that referenced this issue Jul 23, 2020
Closes bazelbuild#11017.

This is the follow-up for PR: [1]. Because of the chicken and the egg
problem, it has to be done in three steps:

1. add support for java toolchange JDK 14, done in: [1]
2. publish new java_tools_javac14, kicked off by the pipeline in
   java_tools repository, in context of: [2]
3. add unit test against released java_tools_javac14 published in step 2,
   this change

Test Plan:

  $ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test

[1] bazelbuild#11514
[2] bazelbuild/java_tools#28
bazel-io pushed a commit to bazelbuild/bazel that referenced this issue Aug 1, 2020
Closes #11017.

This is the follow-up for PR: [1]. Because of the chicken and the egg
problem, it has to be done in three steps:

1. add support for java toolchange JDK 14, done in: [1]
2. publish new java_tools_javac14, kicked off by the pipeline in
   java_tools repository, in context of: [2]
3. add unit test against released java_tools_javac14 published in step 2,
   this change

Test Plan:

  $ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test

[1] #11514
[2] bazelbuild/java_tools#28

Closes #11828.

PiperOrigin-RevId: 324358602
ehkloaj pushed a commit to ehkloaj/bazel that referenced this issue Aug 6, 2020
Closes bazelbuild#11017.

This is the follow-up for PR: [1]. Because of the chicken and the egg
problem, it has to be done in three steps:

1. add support for java toolchange JDK 14, done in: [1]
2. publish new java_tools_javac14, kicked off by the pipeline in
   java_tools repository, in context of: [2]
3. add unit test against released java_tools_javac14 published in step 2,
   this change

Test Plan:

  $ bazel test //src/test/shell/bazel:bazel_coverage_java_jdk14toolchain_released_test

[1] bazelbuild#11514
[2] bazelbuild/java_tools#28

Closes bazelbuild#11828.

PiperOrigin-RevId: 324358602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants