Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport .bazelrc support from Hirschgarten #6854

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agluszak
Copy link
Collaborator

@agluszak agluszak commented Oct 5, 2024

Original author in Hirschgarten: @mtoader

TODO:

  • split off changes related to introduction of kotlin
  • backport tests

@mtoader
Copy link
Contributor

mtoader commented Oct 5, 2024

Heads up: This will be a source of issues for now :) the flags database is minimal and incomplete and it will trigger all kinds of red things in .bazelrc files. I would disable the annotator in here until the known flags database is more coherent.

@mtoader
Copy link
Contributor

mtoader commented Oct 5, 2024

Heads up: This will be a source of issues for now :) the flags database is minimal and incomplete and it will trigger all kinds of red things in .bazelrc files. I would disable the annotator in here until the known flags database is more coherent.

Later edit: I see that it is not in here. That's good

@@ -18,10 +19,9 @@ load(
"intellij_unit_test_suite",
)

java_library(
kt_jvm_library(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep bazelrc as a separate library?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base is quite big already, just to speed up compilation time. Also, compilation time of base would be even slower if we started conversion to kotlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants