Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project cannot be built with incompatible_disallow_empty_glob #4040

Closed
limdor opened this issue Oct 23, 2022 · 5 comments
Closed

Project cannot be built with incompatible_disallow_empty_glob #4040

limdor opened this issue Oct 23, 2022 · 5 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin stale Issues or PRs that are stale (no activity for 30 days) topic: bazel Bazel integration (external repositories, aspects, flags, etc) type: bug

Comments

@limdor
Copy link
Contributor

limdor commented Oct 23, 2022

Description of the bug:

Project cannot be built with incompatible_disallow_empty_glob

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Just build adding --incompatible_disallow_empty_glob

Which Intellij IDE are you using? Please provide the specific version.

None, it is when building the plugin

What programming languages and tools are you using? Please provide specific versions.

Not relevant

What Bazel plugin version are you using?

The one from the master branch

Have you found anything relevant by searching the web?

bazelbuild/bazel#15327
bazelbuild/bazel#8195

Any other information, logs, or outputs that you want to share?

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1307#0183f814-adfb-484a-91e9-7608fe55a095

@limdor limdor mentioned this issue Oct 23, 2022
3 tasks
@sgowroji sgowroji added type: bug product: IntelliJ IntelliJ plugin topic: bazel Bazel integration (external repositories, aspects, flags, etc) awaiting-maintainer Awaiting review from Bazel team on issues labels Oct 26, 2022
@mai93 mai93 assigned mai93 and unassigned HaimingTian Nov 4, 2022
@mai93 mai93 added P1 I'll work on this now. (Assignee required) and removed awaiting-maintainer Awaiting review from Bazel team on issues labels Nov 15, 2022
@mai93 mai93 added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P1 I'll work on this now. (Assignee required) labels Jan 10, 2023
@mai93 mai93 removed their assignment Jan 10, 2023
@keertk keertk moved this to Triaged in Bazel IntelliJ Plugin Feb 27, 2023
@keertk keertk moved this to Triaged in Bazel IntelliJ Plugin Feb 27, 2023
@keertk keertk moved this from Triaged to Backlog in Bazel IntelliJ Plugin Mar 17, 2023
@github-actions
Copy link

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-maintainer". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 12, 2023
@limdor
Copy link
Contributor Author

limdor commented Jul 12, 2023

@bazelbuild/triage consider keeping it. Without it the project will fail to build once flipped

@github-actions github-actions bot removed the stale Issues or PRs that are stale (no activity for 30 days) label Jul 13, 2023
@limdor
Copy link
Contributor Author

limdor commented Jan 5, 2024

This is the current error: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1760#018cccd6-d636-474e-9ebf-9b5dd04cbc69/2963

(01:16:31) WARNING: Option 'remote_default_platform_properties' is deprecated: --remote_default_platform_properties has been deprecated in favor of --remote_default_exec_properties.
--
  | (01:16:31) ERROR: Traceback (most recent call last):
  | File "/var/lib/buildkite-agent/builds/bk-docker-5rgn/bazel-org-repo-root/intellij/cpp/BUILD", line 23, column 16, in <toplevel>
  | srcs = glob([
  | Error in glob: glob pattern 'src/com/google/idea/blaze/cpp/includes/*.java' didn't match anything, but allow_empty is set to False (the default value of allow_empty can be set with --incompatible_disallow_empty_glob).
  | (01:16:31) ERROR: no such target '//cpp:integration_tests': target 'integration_tests' not declared in package 'cpp' defined by /var/lib/buildkite-agent/builds/bk-docker-5rgn/bazel-org-repo-root/intellij/cpp/BUILD
  | (01:16:31) ERROR: no such target '//cpp:unit_tests': target 'unit_tests' not declared in package 'cpp' defined by /var/lib/buildkite-agent/builds/bk-docker-5rgn/bazel-org-repo-root/intellij/cpp/BUILD
  | (01:16:31) ERROR: error loading package 'cpp': Package 'cpp' contains errors

Copy link

github-actions bot commented Jul 7, 2024

Thank you for contributing to the IntelliJ repository! This issue has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jul 7, 2024
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Bazel IntelliJ Plugin Jul 21, 2024
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Oct 7, 2024
This PR is to flip the default value of `incompatible_disallow_empty_glob`. This flag is tracked in #8195 and it is available since Bazel 0.29 from August 2019.
Once this is merged, users still can allow empty globs without being explicit setting `--incompatible_disallow_empty_glob=false`.

The motivation of the flip is bazel-contrib/SIG-rules-authors#37 and the fact of not keeping an incompatible flag for 4 years without flipping it.

What needs to be done before flipping this:

- [x] Merge protocolbuffers/upb#584
- [x] Update upb to a version that has the change in protocolbuffers/upb#584
- [x] Merge protocolbuffers/upb#745
- [x] Bring the changes from protocolbuffers/upb#745 to the 21.x branch
- [x] Bring the changes from protocolbuffers/upb@e5f2601 to the 21.x branch (protocolbuffers/upb#781)
- [x] Update upb to the latest commit of the 21.x branch (#16343)
- [x] Merge #15374
- [x] Merge #15339
- [x] Merge #15330
- [x] Merge #16431
- [x] Merge #16468
- [x] Get green checks for this PR
- [ ] Fix failures in downstream projects: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags
  - [ ] Fix empty globs from IntellIJ Plugin (https://github.com/bazelbuild/intellij)
    - [ ] Issue: bazelbuild/intellij#4040
    - [ ] Android Studio Plugin
    - [ ] Android Studio Plugin Google
    - [ ] CLion Plugin
    - [ ] CLion Plugin Google
    - [ ] IntelliJ Plugin
    - [ ] IntelliJ Plugin Aspect
    - [ ] IntelliJ Plugin Aspect Google
    - [ ] IntelliJ Plugin Google
    - [ ] IntelliJ UE Plugin
    - [ ] IntelliJ UE Plugin Google
    - Opened PRs
      - [x] bazelbuild/intellij#4025
      - [x] bazelbuild/intellij#4038
  - [x] Fix empty globs from Bazel Bench (https://github.com/bazelbuild/bazel-bench)
    - [ ] bazelbuild/bazel-bench#174
    - [x] bazelbuild/bazel-bench#149
  - [x] Fix empty globs from Buildfarm (https://github.com/bazelbuild/bazel-buildfarm)
  - [x] Fix empty globs from Cargo
  - [x] ~~Fix empty globs from Cartographer (https://github.com/cartographer-project/cartographer)~~ (No longer maintained)
    - Issue: cartographer-project/cartographer#1908
    - PR to enforce it cartographer-project/cartographer#1944
  - [x] Fix empty globs from Cloud Robotics Core (https://github.com/googlecloudrobotics/core/)
    - [x] PR to prevent regresions googlecloudrobotics/core#279
  - [ ] Fix empty globs from Envoy
  - [x] Fix empty globs from FlatBuffers
  - [x] Fix empty globs from Flogger
  - [ ] Fix empty globs from Gerrit (https://gerrit.googlesource.com/gerrit.git)
    - Issue: https://issues.gerritcodereview.com/issues/40011754
  - [x] Fix empty globs from :bazel:Protobuf
  - [x] Fix empty globs from rules_android_ndk
  - [ ] Fix empty globs from rules_dotnet
  - [x] Fix empty globs from :bazel:rules_foreign_cc bazel-contrib/rules_foreign_cc#974
  - [x] Fix empty globs from rules_go
  - [x] Fix empty globs from rules_haskell tweag/rules_haskell#1827
  - [x] Fix empty globs from :bazel:rules_jvm_external
  - [x] Fix empty globs from rules_kotlin
  - [x] Fix empty globs from rules_nodejs
  - [x] Fix empty globs from :bazel:rules_python
  - [ ] Fix empty globs from rules_rust
  - [x] Fix empty globs from rules_swift
  - [x] Fix empty globs from rules_webtesting
  - [x] Fix empty globs from TensorFlow  tensorflow/tensorflow#58155
    - [x] tensorflow/tensorflow#58008
    - [x] tensorflow/tensorflow#58154
  - [x] Fix empty globs from upb

RELNOTES[INC]: The flag `--incompatible_disallow_empty_glob` now defaults to true.

Closes #15327.

PiperOrigin-RevId: 683316885
Change-Id: Id34ffd32a9e979fada9207e475b826a508100ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) product: IntelliJ IntelliJ plugin stale Issues or PRs that are stale (no activity for 30 days) topic: bazel Bazel integration (external repositories, aspects, flags, etc) type: bug
Projects
Development

No branches or pull requests

4 participants