Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --incompatible_package_name_is_a_function from Android Testing #417

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Remove --incompatible_package_name_is_a_function from Android Testing #417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions buildkite/pipelines/android-testing-postsubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@
---
platforms:
ubuntu1404:
build_flags:
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
build_targets:
- "//ui/..."
test_flags:
- "--local_test_jobs=8" # Run at most 8 tests (= emulators) in parallel
- "--flaky_test_attempts=3" # Flakes.
- "--spawn_strategy=standalone" # Reduce flakes.
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
test_targets:
- "//ui/espresso/RecyclerViewSample:RecyclerViewSampleInstrumentationTest_23_x86"
- "//ui/espresso/IntentsBasicSample:IntentsBasicSampleInstrumentationTest_23_x86"
Expand All @@ -19,15 +16,12 @@ platforms:
- "//ui/espresso/CustomMatcherSample:CustomMatcherSampleInstrumentationTest_23_x86"
- "//ui/espresso/BasicSample:BasicSampleInstrumentationTest_23_x86"
ubuntu1604:
build_flags:
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
build_targets:
- "//ui/..."
test_flags:
- "--local_test_jobs=8" # Run at most 8 tests (= emulators) in parallel
- "--flaky_test_attempts=3" # Flakes.
- "--spawn_strategy=standalone" # Reduce flakes.
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
test_targets:
- "//ui/espresso/RecyclerViewSample:RecyclerViewSampleInstrumentationTest_23_x86"
- "//ui/espresso/IntentsBasicSample:IntentsBasicSampleInstrumentationTest_23_x86"
Expand All @@ -36,15 +30,12 @@ platforms:
- "//ui/espresso/CustomMatcherSample:CustomMatcherSampleInstrumentationTest_23_x86"
- "//ui/espresso/BasicSample:BasicSampleInstrumentationTest_23_x86"
ubuntu1804:
build_flags:
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
build_targets:
- "//ui/..."
test_flags:
- "--local_test_jobs=8" # Run at most 8 tests (= emulators) in parallel
- "--flaky_test_attempts=3" # Flakes.
- "--spawn_strategy=standalone" # Reduce flakes.
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
test_targets:
- "//ui/espresso/RecyclerViewSample:RecyclerViewSampleInstrumentationTest_23_x86"
- "//ui/espresso/IntentsBasicSample:IntentsBasicSampleInstrumentationTest_23_x86"
Expand All @@ -54,8 +45,6 @@ platforms:
- "//ui/espresso/BasicSample:BasicSampleInstrumentationTest_23_x86"
macos:
# Testing does not work for macos and windows yet
build_flags:
- "--incompatible_package_name_is_a_function=false" # Remove when android/android-test is updated to use updated protobuf https://github.com/protocolbuffers/protobuf/pull/4650
build_targets: # Results of `bazel query 'kind(android_binary, //...)'
- "//ui/uiautomator/BasicSample:BasicSampleTest"
- "//ui/uiautomator/BasicSample:BasicSample"
Expand Down