Added s390x arch support #1265
Merged
Added s390x arch support #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repana-Chowdappa
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
|
@vladmos @pmbethe09 @larsrc-google - Can you please check and approve this PR. |
|
@vladmos @pmbethe09 @larsrc-google - This is blocking rules_rust and kong CI completion for s390x arch to add s390x support. Buildifier is dependency for rust_rules and kong. Please help us in reviewing this PR. |
|
I'll cut a new release in an hour. |
This was referenced Aug 27, 2024
|
@vladmos - I don't see s390x binaries on https://github.com/bazelbuild/buildtools/releases/download/v7.3.1/ after new release. Please let us know whether s390x binaries are built or not. |
|
The binaries were not configured for Github releases. I uploaded them this time manually, #1289 is a permanent fix. |
|
Thanks @vladmos for quick help. may i know from where I can get sha256 values for these binaries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently buildtools repo doesn't a downloadable s390x binary yet for buildifier, buildozer. I tried to build buildtools on s390x and it actually builds fine. Need to include s390x arch binaries in https://github.com/bazelbuild/buildtools/releases/.